Definition Of Done
The “definition of done” is a list of implicit acceptance criteria for stories. These items must be performed for stories to be considered complete.
All Software
Tests - Appropriate Unit, Functional, Performance, and E2E tests are created. We have 80% code coverage.
Inline code comments are present when code is not easily interpreted by others.
Readable and linted code.
Meets compliance requirements [CCPA, GDPR, PCI, ARIA]
Frontend
Browser support
Browser VERSION_START - VERSION_END
Responsive
Horizontal - MIN - MAX
VERTICAL - MIN
Matches the design spec
DESIGN SYSTEM GUIDELINES
Accessible
No double scrollbars
Code follows folder and file structure conventions (modlets)
Storybook - Stories are created for 70% of components.
Progressively loaded pages
Loading, resolved, and error states and empty data are handled for every request
Backend
No click-ops
Migrations
Follow API conventions - API_CONVENTIONS
Update API documentation